RE: [PATCH v5 0/4] perf vendor events: Support PMU events for A64FX

Hi, John

quoted

Apart from that, I think that we're a bit uncertain about patch 3/4

What are your concerns?
I think it's okay for perf to read a new event code with a number at the beginning.

The impact of this fix is on {name} and later rules.
parse_events.l uses {name} only in one place.
The only rule defined after {name} is {name_tag}.

I think the point of current fix is that the rules defined after {name} are not misrecognize and the syntax is not broken. 
{name_tag} starts with ', but {name} does not contain'.
Therefore, the corrected {name} does not misrecognize the {name_tag}, and I think there is no problem.

Best Regards
Shunsuke

-----Original Message-----
From: linux-arm-kernel <redacted> On
Behalf Of nakamura.shun@fujitsu.com
Sent: Wednesday, February 3, 2021 4:02 PM
To: 'John Garry' <redacted>; will@kernel.org;
mathieu.poirier@linaro.org; leo.yan@linaro.org; peterz@infradead.org;
mingo@redhat.com; acme@kernel.org; mark.rutland@arm.com;
alexander.shishkin@linux.intel.com; jolsa@redhat.com; namhyung@kernel.org
Cc: linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org
Subject: RE: [PATCH v5 0/4] perf vendor events: Support PMU events for A64FX

Hi, John

quoted

Just some things to note:
- please pick up and apply reviewed-by tags granted from previous
reviews if explicitly granted, subject to making any trivial changes
requested If any significant changes are made, then don't pick up
theses tags or drop them (if they were picked up earlier)

I will fix.

quoted

- I'd say that it's best not to send my patch in 1/4, but better to
mention the series which this is based on in your cover letter Sending
my patch is only going to make the maintainers (Arnaldo) life more difficult to

track these things.
I will fix.

quoted

Apart from that, I think that we're a bit uncertain about patch 3/4

What are your concerns?
I think it's okay for perf to read a new event code with a number at the beginning.

Best Regards
Shunsuke

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel