Re: Re: [PATCH v4] ARM: dts: sun7i: a20: bananapro: Fix ethernet phy-mode
From: Hermann Lauer <hidden>
Date: 2021-02-01 12:10:06
Also in:
linux-devicetree, lkml
On Thu, Jan 28, 2021 at 03:59:37PM +0100, Maxime Ripard wrote:
On Thu, Jan 28, 2021 at 12:18:42PM +0100, Hermann.Lauer@uni-heidelberg.de wrote:quoted
BPi Pro needs TX and RX delay for Gbit to work reliable and avoid high packet loss rates. The realtek phy driver overrides the settings of the pull ups for the delays, so fix this for BananaPro. Fix the phy-mode description to correctly reflect this so that the implementation doesn't reconfigure the delays incorrectly. This happened with commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e rx/tx delay config"). Fixes: 10662a33dcd9 ("ARM: dts: sun7i: Add dts file for Bananapro board") Signed-off-by: Hermann Lauer <redacted>Applied since it's a fix simple enough, but please provide a changelog between versions.
v3 added the correct fixes tag, where the problem originated (initial commit of banana pro device tree). That worked in the past until a change in the phy device driver for realtek phy on banana pro overrode the phyical configuration of the hardware pull-ups. v4 added the commit which implemented that driver change (shamelessly stolen from the commit of the fix of the identical problem on the banana pi) Thanks, greetings Hermann -- Administration/Zentrale Dienste, Interdiziplinaeres Zentrum fuer wissenschaftliches Rechnen der Universitaet Heidelberg IWR; INF 205; 69120 Heidelberg; Tel: (06221)54-14405 Fax: -14427 Email: Hermann.Lauer@iwr.uni-heidelberg.de _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel