Re: [PATCH v1 2/2] arm64: configs: Support DEVAPC on MediaTek platforms

On Sun, Jan 31, 2021 at 3:07 PM Matthias Brugger [off-list ref] wrote:

On 23/12/2020 09:44, Neal Liu wrote:

quoted

Support DEVAPC on MediaTek platforms by enabling CONFIG_MTK_DEVAPC.

Signed-off-by: Neal Liu <redacted>
---
 arch/arm64/configs/defconfig |    1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 17a2df6..a373776 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig

@@ -257,6 +257,7 @@ CONFIG_MTD_NAND_MARVELL=y
 CONFIG_MTD_NAND_FSL_IFC=y
 CONFIG_MTD_NAND_QCOM=y
 CONFIG_MTD_SPI_NOR=y
+CONFIG_MTK_DEVAPC=m
 CONFIG_SPI_CADENCE_QUADSPI=y
 CONFIG_BLK_DEV_LOOP=y
 CONFIG_BLK_DEV_NBD=m

From my understanding, defconfig is for a minimal config that allows to boot a
machine. As MTK_DEVAPC is a rather exotic driver to detect bus access
violations, I think it's not a good candidate for inclusion in defconfig.

In any case, I added the SoC maintainer, so that they can correct me, if I'm
wrong :)

I generally don't mind adding platform specific drivers as loadable modules
even if they are somewhat obscure. For built-in drivers, this is
different though,
as those have a noticeable impact on other platforms.

I haven't kept track of what this particular driver does, but from the Kconfig
description, I'd say it should get enabled in defconfig.

        Arnd

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

On 31/01/2021 23:23, Arnd Bergmann wrote:

On Sun, Jan 31, 2021 at 3:07 PM Matthias Brugger [off-list ref] wrote:

quoted

On 23/12/2020 09:44, Neal Liu wrote:

quoted

Support DEVAPC on MediaTek platforms by enabling CONFIG_MTK_DEVAPC.

Signed-off-by: Neal Liu <redacted>
---
 arch/arm64/configs/defconfig |    1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 17a2df6..a373776 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig

@@ -257,6 +257,7 @@ CONFIG_MTD_NAND_MARVELL=y
 CONFIG_MTD_NAND_FSL_IFC=y
 CONFIG_MTD_NAND_QCOM=y
 CONFIG_MTD_SPI_NOR=y
+CONFIG_MTK_DEVAPC=m
 CONFIG_SPI_CADENCE_QUADSPI=y
 CONFIG_BLK_DEV_LOOP=y
 CONFIG_BLK_DEV_NBD=m

From my understanding, defconfig is for a minimal config that allows to boot a
machine. As MTK_DEVAPC is a rather exotic driver to detect bus access
violations, I think it's not a good candidate for inclusion in defconfig.

In any case, I added the SoC maintainer, so that they can correct me, if I'm
wrong :)

I generally don't mind adding platform specific drivers as loadable modules
even if they are somewhat obscure. For built-in drivers, this is
different though,
as those have a noticeable impact on other platforms.

I haven't kept track of what this particular driver does, but from the Kconfig
description, I'd say it should get enabled in defconfig.

Thanks for the feedback Arnd.
Applied now to v5.11-next/defconfig

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel