Thread (5 messages) flat view 5 messages, 2 authors, 2021-01-29

Re: [PATCH] counter: stm32-lptimer-cnt: remove iio counter abi

From: William Breathitt Gray <hidden>
Date: 2021-01-29 08:36:55

On Fri, Jan 22, 2021 at 04:03:23PM +0100, Fabrice Gasnier wrote:
Currently, the STM32 LP Timer counter driver registers into both IIO and
counter subsystems, which is redundant.

Remove the IIO counter ABI and IIO registration from the STM32 LP Timer
counter driver since it's been superseded by the Counter subsystem
as discussed in [1].

Keep only the counter subsystem related part.
Move a part of the ABI documentation into a driver comment.

This also removes a duplicate ABI warning
$ scripts/get_abi.pl validate
...
/sys/bus/iio/devices/iio:deviceX/in_count0_preset is defined 2 times:
  ./Documentation/ABI/testing/sysfs-bus-iio-timer-stm32:100
  ./Documentation/ABI/testing/sysfs-bus-iio-lptimer-stm32:0

[1] https://lkml.org/lkml/2021/1/19/347

Signed-off-by: Fabrice Gasnier <fabrice.gasnier@foss.st.com>
---
 .../ABI/testing/sysfs-bus-iio-lptimer-stm32        |  62 -----
 drivers/counter/stm32-lptimer-cnt.c                | 297 +++------------------
 2 files changed, 36 insertions(+), 323 deletions(-)
 delete mode 100644 Documentation/ABI/testing/sysfs-bus-iio-lptimer-stm32
Hi Fabrice,

I noticed this is missing a Kconfig change to remove the IIO dependency
from the STM32_LPTIMER_CNT config option. I assume that dependency is no
longer necessary with the IIO code is removed.

William Breathitt Gray
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help