Re: [PATCH 2/2] ARM: dts: sti: Introduce 4KOpen (stih418-b2264) board

On Thu, Jan 28, 2021 at 8:58 AM Alain Volmat [off-list ref] wrote:

4KOpen (B2264) is a board based on the STMicroelectronics STiH418 soc:
  - 2GB DDR
  - HDMI
  - Ethernet 1000-BaseT
  - PCIe (mini PCIe connector)
  - MicroSD slot
  - USB2 and USB3 connectors
  - Sata
  - 40 pins GPIO header

Signed-off-by: Alain Volmat <redacted>

The changelog text seems fine here.

+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * Copyright (C) 2021 STMicroelectronics
+ * Author: Alain Volmat [off-list ref]
+ */
+/dts-v1/;
+#include "stih418.dtsi"
+#include <dt-bindings/gpio/gpio.h>
+/ {
+       model = "STiH418 B2264";
+       compatible = "st,stih418-b2264", "st,stih418";
+
+       chosen {
+               bootargs = "console=ttyAS0,115200 clk_ignore_unused";
+               stdout-path = &sbc_serial0;
+       };

I don't think the bootargs should be there, both are just hacks
when things don't work correctly. If they don't, then try to fix them
first, by making sure that all clocks are properly listed, and that the
stdou-path points the working console.

+&rng11 {
+       status = "disabled";
+};

Why do you disable the random number generator?

       Arnd

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel