From: Marek Szyprowski <m.szyprowski@samsung.com> Date: 2021-01-22 05:54:33
For the proper reboot Odroid-C4 board requires to switch TFLASH_VDD_EN
pin to the high impedance mode, otherwise the board is stuck in the
middle of loading early stages of the bootloader from SD card.
This can be achieved by using the OPEN_DRAIN flag instead of the
ACTIVE_HIGH, what will leave the pin in input mode to achieve high state
(pin has the pull-up) and solve the issue.
Suggested-by: Neil Armstrong <redacted>
Fixes: 326e57518b0d ("arm64: dts: meson-sm1: add support for Hardkernel ODROID-C4")
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
---
Here is a discussion on u-boot's mailing list that inspired this patch:
https://lists.denx.de/pipermail/u-boot/2020-December/435295.html
Changelog:
v2:
- fixed typo in the commit message
v1: https://lore.kernel.org/linux-amlogic/20201218102228.16211-1-m.szyprowski@samsung.com/
- initial version
---
arch/arm64/boot/dts/amlogic/meson-sm1-odroid-c4.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
From: Neil Armstrong <hidden> Date: 2021-01-25 18:39:27
On 22/01/2021 06:52, Marek Szyprowski wrote:
quoted hunk
For the proper reboot Odroid-C4 board requires to switch TFLASH_VDD_EN
pin to the high impedance mode, otherwise the board is stuck in the
middle of loading early stages of the bootloader from SD card.
This can be achieved by using the OPEN_DRAIN flag instead of the
ACTIVE_HIGH, what will leave the pin in input mode to achieve high state
(pin has the pull-up) and solve the issue.
Suggested-by: Neil Armstrong <redacted>
Fixes: 326e57518b0d ("arm64: dts: meson-sm1: add support for Hardkernel ODROID-C4")
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
---
Here is a discussion on u-boot's mailing list that inspired this patch:
https://lists.denx.de/pipermail/u-boot/2020-December/435295.html
Changelog:
v2:
- fixed typo in the commit message
v1: https://lore.kernel.org/linux-amlogic/20201218102228.16211-1-m.szyprowski@samsung.com/
- initial version
---
arch/arm64/boot/dts/amlogic/meson-sm1-odroid-c4.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Hi Kevin,
The same fix was pushed on u-boot and solves the issue.
Could you take it for fixes ?
Acked-by: Neil Armstrong <redacted>
Neil
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
From: Kevin Hilman <khilman@baylibre.com> Date: 2021-01-25 18:45:19
On Fri, 22 Jan 2021 06:52:18 +0100, Marek Szyprowski wrote:
For the proper reboot Odroid-C4 board requires to switch TFLASH_VDD_EN
pin to the high impedance mode, otherwise the board is stuck in the
middle of loading early stages of the bootloader from SD card.
This can be achieved by using the OPEN_DRAIN flag instead of the
ACTIVE_HIGH, what will leave the pin in input mode to achieve high state
(pin has the pull-up) and solve the issue.
Applied, thanks!
[1/1] arm64: dts: meson: switch TFLASH_VDD_EN pin to open drain on Odroid-C4
commit: c649d91a8ec4dda78bcbd3890156bffb4df2fa16
Best regards,
--
Kevin Hilman [off-list ref]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel