Thread (11 messages) 11 messages, 5 authors, 2021-01-27

Re: [PATCH 5/6] gpiolib: Fix return check of __irq_domain_alloc_irqs

From: Andy Shevchenko <hidden>
Date: 2021-01-04 15:01:18
Also in: linux-gpio

On Sat, Jan 2, 2021 at 8:24 PM Adam Lackorzynski [off-list ref] wrote:
0 is not a proper IRQ number and also indicates failure.
Hmm... While in this case it's perhaps okay, this does not work in
general since the function can take irq_base == 0 and realloc == true.
So if we want to have a code that somebody may reuse better not to do
this (we never get 0 from this function).

In my humble opinion NAK.

-- 
With Best Regards,
Andy Shevchenko

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help