Re: [PATCH v2] of/device: Update dma_range_map only when dev has valid dma-ranges
From: Rob Herring <robh@kernel.org>
Date: 2021-01-27 20:03:26
Also in:
linux-devicetree, linux-iommu, linux-mediatek, lkml
On Tue, 19 Jan 2021 18:52:03 +0800, Yong Wu wrote:
The commit e0d072782c73 ("dma-mapping: introduce DMA range map,
supplanting dma_pfn_offset") always update dma_range_map even though it was
already set, like in the sunxi_mbus driver. the issue is reported at [1].
This patch avoid this(Updating it only when dev has valid dma-ranges).
Meanwhile, dma_range_map contains the devices' dma_ranges information,
This patch moves dma_range_map before of_iommu_configure. The iommu
driver may need to know the dma_address requirements of its iommu
consumer devices.
[1] https://lore.kernel.org/linux-arm-kernel/5c7946f3-b56e-da00-a750-be097c7ceb32@arm.com/ (local)
CC: Rob Herring <robh+dt@kernel.org>
CC: Frank Rowand <redacted>
Fixes: e0d072782c73 ("dma-mapping: introduce DMA range map, supplanting dma_pfn_offset"),
Suggested-by: Robin Murphy <robin.murphy@arm.com>
Signed-off-by: Yong Wu <yong.wu@mediatek.com>
Signed-off-by: Paul Kocialkowski <redacted>
Reviewed-by: Rob Herring <robh@kernel.org>
---
drivers/of/device.c | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)Applied, thanks! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel