Re: [PATCH v9 10/18] arm64: kexec: cpu_soft_restart change argument types

On Wed, Apr 29, 2020 at 1:01 PM James Morse [off-list ref] wrote:

Hi Pavel,

On 26/03/2020 03:24, Pavel Tatashin wrote:

quoted

Change argument types from unsigned long to a more descriptive
phys_addr_t.

For 'entry', which is a physical addresses, sure...

quoted

diff --git a/arch/arm64/kernel/cpu-reset.h b/arch/arm64/kernel/cpu-reset.h
index ed50e9587ad8..38cbd4068019 100644
--- a/arch/arm64/kernel/cpu-reset.h
+++ b/arch/arm64/kernel/cpu-reset.h

@@ -10,17 +10,17 @@

 #include <asm/virt.h>

-void __cpu_soft_restart(unsigned long el2_switch, unsigned long entry,
-     unsigned long arg0, unsigned long arg1, unsigned long arg2);

quoted

+void __cpu_soft_restart(phys_addr_t el2_switch, phys_addr_t entry,
+                     phys_addr_t arg0, phys_addr_t arg1, phys_addr_t arg2);

This looks weird because its re-using the hyp-stub API, because it might call the hyp-stub
from the idmap. entry is passed in, so this isn't tied to kexec. Without tying it to
kexec, how do you know arg2 is a physical address?
I think it tried to be re-usable because 32bit has more users for this.

I will drop this patch. It was intended as a cleanup from suggestions
in earlier versions of this series, but I see it is not really needed.

Thank you,
Pasha

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel