RE: [PATCH v3 4/4] hwmon: Support Aspeed AST2600 PWM/Fan tachometer
From: Ryan Chen <ryan_chen@aspeedtech.com>
Date: 2021-01-20 05:30:33
Also in:
linux-aspeed, lkml, openbmc
-----Original Message----- From: Andrew Jeffery <redacted> Sent: Wednesday, January 20, 2021 1:16 PM To: Troy Lee <redacted>; openbmc@lists.ozlabs.org; Joel Stanley [off-list ref]; Philipp Zabel [off-list ref]; open list [off-list ref]; moderated list:ARM/ASPEED MACHINE SUPPORT [off-list ref]; moderated list:ARM/ASPEED MACHINE SUPPORT [off-list ref] Cc: Ryan Chen <ryan_chen@aspeedtech.com>; ChiaWei Wang [off-list ref]; Troy Lee [off-list ref]; kbuild test robot [off-list ref] Subject: Re: [PATCH v3 4/4] hwmon: Support Aspeed AST2600 PWM/Fan tachometer Hi Troy, On Mon, 18 Jan 2021, at 17:20, Troy Lee wrote:quoted
Add Aspeed AST2600 PWM/Fan tacho driver. AST2600 has 16 PWM channel and 16 FAN tacho channel. Changes since v2: - declare local function as static function Changes since v1: - fixed review comments - fixed double-looped calculation of div_h and div_l - moving configuration to device tree - register hwmon driver with devm_hwmon_device_register_with_info() Signed-off-by: Troy Lee <redacted> Reported-by: kernel test robot <redacted> --- drivers/hwmon/Kconfig | 10 + drivers/hwmon/Makefile | 1 + drivers/hwmon/aspeed2600-pwm-tacho.c | 756 +++++++++++++++++++++++++++ 3 files changed, 767 insertions(+) create mode 100644 drivers/hwmon/aspeed2600-pwm-tacho.c...quoted
diff --git a/drivers/hwmon/Makefile b/drivers/hwmon/Makefile index09a86c5e1d29..1a415d493ffc 100644--- a/drivers/hwmon/Makefile +++ b/drivers/hwmon/Makefile@@ -52,6 +52,7 @@ obj-$(CONFIG_SENSORS_ARM_SCPI) +=scpi-hwmon.oquoted
obj-$(CONFIG_SENSORS_AS370) += as370-hwmon.o obj-$(CONFIG_SENSORS_ASC7621) += asc7621.o obj-$(CONFIG_SENSORS_ASPEED) += aspeed-pwm-tacho.o +obj-$(CONFIG_SENSORS_ASPEED2600_PWM_TACHO) +=aspeed2600-pwm-tacho.o Why does this have to be a separate implementation from the existing ASPEED PWM/Tacho driver? Is there really nothing in common?
Hello Andrew, The register set is fully re-arrange. And it is new design at AST2600, can't be compatible with older PWM. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel