Re: [PATCH v4 01/21] arm64: Fix labels in el2_setup macros
From: David Brazdil <hidden>
Date: 2021-01-18 11:25:27
Also in:
kvmarm, lkml
From: David Brazdil <hidden>
Date: 2021-01-18 11:25:27
Also in:
kvmarm, lkml
On Mon, Jan 18, 2021 at 09:45:13AM +0000, Marc Zyngier wrote:
If someone happens to write the following code: b 1f init_el2_state vhe 1: [...] they will be in for a long debugging session, as the label "1f" will be resolved *inside* the init_el2_state macro instead of after it. Not really what one expects. Instead, rewite the EL2 setup macros to use unambiguous labels, thanks to the usual macro counter trick. Acked-by: Catalin Marinas <catalin.marinas@arm.com> Signed-off-by: Marc Zyngier <maz@kernel.org> --- arch/arm64/include/asm/el2_setup.h | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-)
Acked-by: David Brazdil <redacted> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel