On Fri, Jan 15, 2021 at 02:53:32PM +0100, Steen Hegelund wrote:

The MAC address is 1 byte?

+    description:
+      Specifies the MAC address that is used as the template for the MAC
+      addresses assigned to the ports provided by the driver.  If not provided
+      a randomly generated MAC address will be used.
+
+  ethernet-ports:
+    type: object
+    properties:
+      '#address-cells':
+        const: 1
+      '#size-cells':
+        const: 0
+
+    patternProperties:
+      "^port@[0-9]+$":

Unit-addresses are hex.

+        type: object
+        description: Switch ports
+
+        allOf:
+          - $ref: ethernet-controller.yaml#
+
+        properties:
+          reg:
+            description: Switch port number
+
+          bandwidth:

Needs a vendor prefix.

+            maxItems: 1

Not an array. Drop.

+            $ref: /schemas/types.yaml#definitions/uint32
+            description: Specifies bandwidth in Mbit/s allocated to the port.

0-2^32 allowed?

+
+          phys:
+            maxItems: 1
+            description:
+              phandle of a Ethernet SerDes PHY.  This defines which SerDes
+              instance will handle the Ethernet traffic.
+
+          phy-handle:
+            maxItems: 1

Always a single item. (Note phys is not, so that's correct.)

+            description:
+               phandle of a Ethernet PHY.  This is optional and if provided it
+               points to the cuPHY used by the Ethernet SerDes.
+
+          phy-mode:
+            maxItems: 1

Not an array. Drop.

I'd assume it's some subset of modes?

+            description:
+              This specifies the interface used by the Ethernet SerDes towards the
+              phy or SFP.
+
+          sfp:
+            maxItems: 1

'sfp' is already defined as a single item. Drop

+            description:
+              phandle of an SFP.  This is optional and used when not specifying
+              a cuPHY.  It points to the SFP node that describes the SFP used by
+              the Ethernet SerDes.
+
+          managed:
+            maxItems: 1
+            description:
+              SFP management. This must be provided when specifying an SFP.

'managed: true' is sufficient. It's already described in 
ethernet-controller.yaml and the schema expresses the 2nd sentence.

+
+          sd_sgpio:

Vendor specific? Then needs a vendor prefix.

s/_/-/

+            $ref: /schemas/types.yaml#/definitions/uint32
+            maxItems: 1

A uint32 is always 1 item. Drop.

+            description:
+              Index of the ports Signal Detect SGPIO in the set of 384 SGPIOs
+              This is optional, and only needed if the default used index is
+              is not correct.

Sounds like constraints?:

minimum: 0
maximum: 383

+
+        required:
+          - reg
+          - bandwidth
+          - phys
+          - phy-mode
+
+        oneOf:
+          - required:
+              - phy-handle
+          - required:
+              - sfp
+              - managed
+
+        additionalProperties: false
+
+required:
+  - compatible
+  - reg
+  - reg-names
+  - interrupts
+  - ethernet-ports
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/interrupt-controller/arm-gic.h>
+    switch: switch@600000000 {
+      compatible = "microchip,sparx5-switch";
+      reg =  <0x10000000 0x800000>,
+             <0x11010000 0x1b00000>;
+      reg-names = "devices", "gcb";
+
+      interrupts = <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>;
+      ethernet-ports {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        port0: port@0 {
+          reg = <0>;
+          bandwidth = <1000>;
+          phys = <&serdes 13>;
+          phy-handle = <&phy0>;
+          phy-mode = "qsgmii";
+        };
+        /* ... */
+        /* Then the 25G interfaces */
+        port60: port@60 {
+          reg = <60>;
+          bandwidth = <25000>;
+          phys = <&serdes 29>;
+          phy-mode = "10gbase-r";
+          sfp = <&sfp_eth60>;
+          managed = "in-band-status";
+        };
+        port61: port@61 {
+          reg = <61>;
+          bandwidth = <25000>;
+          phys = <&serdes 30>;
+          phy-mode = "10gbase-r";
+          sfp = <&sfp_eth61>;
+          managed = "in-band-status";
+        };
+        port62: port@62 {
+          reg = <62>;
+          bandwidth = <25000>;
+          phys = <&serdes 31>;
+          phy-mode = "10gbase-r";
+          sfp = <&sfp_eth62>;
+          managed = "in-band-status";
+        };
+        port63: port@63 {
+          reg = <63>;
+          bandwidth = <25000>;
+          phys = <&serdes 32>;
+          phy-mode = "10gbase-r";
+          sfp = <&sfp_eth63>;
+          managed = "in-band-status";
+        };
+        /* Finally the Management interface */
+        port64: port@64 {
+          reg = <64>;
+          bandwidth = <1000>;
+          phys = <&serdes 0>;
+          phy-handle = <&phy64>;
+          phy-mode = "sgmii";
+        };
+      };
+    };
+
+...
-- 
2.29.2

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel