Re: [PATCH v3, 09/15] drm/mediatek: Add pm runtime support for gamma
From: Chun-Kuang Hu <chunkuang.hu@kernel.org>
Date: 2021-01-12 23:10:51
Also in:
dri-devel, linux-devicetree, linux-mediatek, lkml
Hi, Yongqiang: Yongqiang Niu [off-list ref] 於 2021年1月11日 週一 下午3:48寫道：
gamma power domain need controled in the device.
In this series, why only gamma and color add pm runtime support? I think all ddp component need pm runtime support. And pm runtime support is not related to mt8192, so move these patches out of this series. Regards, Chun-Kuang.
quoted hunk ↗ jump to hunk
Signed-off-by: Yongqiang Niu <redacted> Signed-off-by: Yidi Lin <redacted> --- drivers/gpu/drm/mediatek/mtk_disp_gamma.c | 5 +++++ 1 file changed, 5 insertions(+)diff --git a/drivers/gpu/drm/mediatek/mtk_disp_gamma.c b/drivers/gpu/drm/mediatek/mtk_disp_gamma.c index 3c1ea07..da93079 100644 --- a/drivers/gpu/drm/mediatek/mtk_disp_gamma.c +++ b/drivers/gpu/drm/mediatek/mtk_disp_gamma.c@@ -10,6 +10,7 @@ #include <linux/of_device.h> #include <linux/of_irq.h> #include <linux/platform_device.h> +#include <linux/pm_runtime.h> #include <linux/soc/mediatek/mtk-cmdq.h> #include "mtk_drm_crtc.h"@@ -156,6 +157,8 @@ static int mtk_disp_gamma_probe(struct platform_device *pdev) platform_set_drvdata(pdev, priv); + pm_runtime_enable(dev); + ret = component_add(dev, &mtk_disp_gamma_component_ops); if (ret) dev_err(dev, "Failed to add component: %d\n", ret);@@ -165,6 +168,8 @@ static int mtk_disp_gamma_probe(struct platform_device *pdev) static int mtk_disp_gamma_remove(struct platform_device *pdev) { + pm_runtime_disable(&pdev->dev); + component_del(&pdev->dev, &mtk_disp_gamma_component_ops); return 0; --1.8.1.1.dirty _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel