Thread (9 messages) 9 messages, 4 authors, 2021-02-08

RE: [PATCH v7 0/2] PCI: cadence: Retrain Link to work around Gen2

From: Athani Nadeem Ladkhan <hidden>
Date: 2021-01-07 19:55:44
Also in: linux-omap, linux-pci, lkml

Hello,

Requesting to provide review comments.

Thanks & Regards,
Nadeem Athani
-----Original Message-----
From: Nadeem Athani <redacted>
Sent: Wednesday, December 30, 2020 5:35 PM
To: Tom Joseph <redacted>; lorenzo.pieralisi@arm.com;
robh@kernel.org; bhelgaas@google.com; kishon@ti.com; linux-
omap@vger.kernel.org; linux-pci@vger.kernel.org; linux-arm-
kernel@lists.infradead.org; linux-kernel@vger.kernel.org
Cc: Athani Nadeem Ladkhan <redacted>; Milind Parab
[off-list ref]; Swapnil Kashinath Jakhade
[off-list ref]; Parshuram Raju Thombare
[off-list ref]
Subject: [PATCH v7 0/2] PCI: cadence: Retrain Link to work around Gen2

Cadence controller will not initiate autonomous speed change if strapped as
Gen2. The Retrain Link bit is set as quirk to enable this speed change.
Adding a quirk flag for defective IP. In future IP revisions this will not be
applicable.

Version history:
Changes in v7:
- Changing the commit title of patch 1 in this series.
- Added a return value for function cdns_pcie_retrain().
Changes in v6:
- Move the position of function cdns_pcie_host_wait_for_link to remove
  compilation error. No changes in code. Separate patch for this.
Changes in v5:
- Remove the compatible string based setting of quirk flag.
- Removed additional Link Up Check
- Removed quirk from pcie-cadence-plat.c and added in pci-j721e.c Changes
in v4:
- Added a quirk flag based on a new compatible string.
- Change of api for link up: cdns_pcie_host_wait_for_link().
Changes in v3:
- To set retrain link bit,checking device capability & link status.
- 32bit read in place of 8bit.
- Minor correction in patch comment.
- Change in variable & macro name.
Changes in v2:
- 16bit read in place of 8bit.

Nadeem Athani (2):
  PCI: cadence: Shifting of a function to support new code.
  PCI: cadence: Retrain Link to work around Gen2 training defect.

 drivers/pci/controller/cadence/pci-j721e.c         |  3 +
 drivers/pci/controller/cadence/pcie-cadence-host.c | 70 ++++++++++++++++-
-----
 drivers/pci/controller/cadence/pcie-cadence.h      | 11 +++-
 3 files changed, 65 insertions(+), 19 deletions(-)

--
2.15.0

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help