Re: [PATCH v2 5/6] PCI: brcmstb: Add panic/die handler to RC driver
From: Bjorn Helgaas <helgaas@kernel.org>
Date: 2021-01-06 19:20:44
Also in:
linux-pci, lkml
From: Bjorn Helgaas <helgaas@kernel.org>
Date: 2021-01-06 19:20:44
Also in:
linux-pci, lkml
On Mon, Nov 30, 2020 at 04:11:42PM -0500, Jim Quinlan wrote:
Whereas most PCIe HW returns 0xffffffff on illegal accesses and the like, by default Broadcom's STB PCIe controller effects an abort. This simple handler determines if the PCIe controller was the cause of the abort and if so, prints out diagnostic info. Example output: brcm-pcie 8b20000.pcie: Error: Mem Acc: 32bit, Read, @0x38000000 brcm-pcie 8b20000.pcie: Type: TO=0 Abt=0 UnspReq=1 AccDsble=0 BadAddr=0
What does this mean for all the other PCI core code that expects 0xffffffff data returns? Does it work? Does it break differently on STB than on other platforms?
+/* + * Dump out pcie errors on die or panic.
s/pcie/PCIe/ This could be a single-line comment.
+ */
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel