Re: [PATCH v5 4/5] arm64: Add support for SMCCC TRNG entropy source

On Tue, 5 Jan 2021 17:00:14 +0000
Mark Brown [off-list ref] wrote:

On Tue, Jan 05, 2021 at 04:36:51PM +0000, Andre Przywara wrote:

quoted

@@ -77,10 +117,20 @@ arch_get_random_seed_long_early(unsigned long

*v) {
 	WARN_ON(system_state != SYSTEM_BOOTING);
 
-	if (!__early_cpu_has_rndr())
-		return false;
+	if (__early_cpu_has_rndr())
+		return __arm64_rndr(v);
+
+	if (smccc_trng_available) {
+		struct arm_smccc_res res;  

This still seems to be preferring RNDR over SMCCC for the early seed
unless I'm misreading the diff?

Argh, my apologies for that blunder. I *did* change it, but must have
lost it when rebasing against my debug patches.
Will send a fixed version in a jiffy.

Cheers,
Andre.


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel