Thread (25 messages) 25 messages, 3 authors, 2021-01-02

Re: [PATCH v3 07/14] crypto: blake2s - add comment for blake2s_state fields

From: Ard Biesheuvel <ardb@kernel.org>
Date: 2020-12-23 09:08:06
Also in: linux-crypto

On Wed, 23 Dec 2020 at 09:12, Eric Biggers [off-list ref] wrote:
From: Eric Biggers <redacted>

The first three fields of 'struct blake2s_state' are used in assembly
code, which isn't immediately obvious, so add a comment to this effect.

Signed-off-by: Eric Biggers <redacted>
Acked-by: Ard Biesheuvel <ardb@kernel.org>
quoted hunk ↗ jump to hunk
---
 include/crypto/blake2s.h | 1 +
 1 file changed, 1 insertion(+)
diff --git a/include/crypto/blake2s.h b/include/crypto/blake2s.h
index 734ed22b7a6aa..f1c8330a61a91 100644
--- a/include/crypto/blake2s.h
+++ b/include/crypto/blake2s.h
@@ -24,6 +24,7 @@ enum blake2s_lengths {
 };

 struct blake2s_state {
+       /* 'h', 't', and 'f' are used in assembly code, so keep them as-is. */
        u32 h[8];
        u32 t[2];
        u32 f[2];
--
2.29.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help