Thread (9 messages) 9 messages, 3 authors, 2020-12-07

Re: [PATCH 3/3] arm64: dts: update device trees to specify clock-frequency in imx219 node

From: Michael Srba <hidden>
Date: 2020-12-06 17:21:29
Also in: linux-devicetree, linux-media, linux-renesas-soc

Hi Michael,

On Sat, Dec 5, 2020 at 7:36 PM [off-list ref] wrote:
quoted
From: Michael Srba <redacted>

This patch adds the clock-frequency property to all device trees that use
the imx219 binding, with the value of exactly 24Mhz which was previously
implicitly assumed.

Signed-off-by: Michael Srba <redacted>
Thanks for your patch!
quoted
--- a/arch/arm64/boot/dts/renesas/aistarvision-mipi-adapter-2.1.dtsi
+++ b/arch/arm64/boot/dts/renesas/aistarvision-mipi-adapter-2.1.dtsi
@@ -82,6 +82,7 @@ imx219: imx219@10 {
                compatible = "sony,imx219";
                reg = <0x10>;
                clocks = <&osc25250_clk>;
+               clock-frequency = <24000000>;
                VANA-supply = <&imx219_vana_2v8>;
                VDIG-supply = <&imx219_vdig_1v8>;
                VDDL-supply = <&imx219_vddl_1v2>;
diff --git a/arch/arm64/boot/dts/renesas/r8a774c0-ek874-mipi-2.1.dts b/arch/arm64/boot/dts/renesas/r8a774c0-ek874-mipi-2.1.dts
index f0829e905506..db4b801b17b5 100644
--- a/arch/arm64/boot/dts/renesas/r8a774c0-ek874-mipi-2.1.dts
+++ b/arch/arm64/boot/dts/renesas/r8a774c0-ek874-mipi-2.1.dts
@@ -59,6 +59,7 @@ &imx219 {
        port {
                imx219_ep: endpoint {
                        clock-lanes = <0>;
+                       clock-frequency = <24000000>;
Why is this change needed? This is not the imx219 node, but its endpoint
subnode (the imx219 is imported from aistarvision-mipi-adapter-2.1.dtsi).
My bad, I must have been really tired.
will rectify this
quoted
                        data-lanes = <1 2>;
                        link-frequencies = /bits/ 64 <456000000>;
                        /* uncomment remote-endpoint property to tie imx219 to
-
Gr{oetje,eeting}s,

                        Geert
Michael

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help