[PATCH AUTOSEL 5.4 05/17] rtc: pl031: fix resource leak in pl031_probe
From: Sasha Levin <sashal@kernel.org>
Date: 2020-12-30 13:10:27
Also in:
linux-rtc, lkml, stable
Subsystem:
arm/nomadik/ux500 architectures, real time clock (rtc) subsystem, the rest · Maintainers:
Linus Walleij, Alexandre Belloni, Linus Torvalds
From: Zheng Liang <redacted> [ Upstream commit 1eab0fea2514b269e384c117f5b5772b882761f0 ] When devm_rtc_allocate_device is failed in pl031_probe, it should release mem regions with device. Reported-by: Hulk Robot <redacted> Signed-off-by: Zheng Liang <redacted> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Acked-by: Linus Walleij <redacted> Link: https://lore.kernel.org/r/20201112093139.32566-1-zhengliang6@huawei.com (local) Signed-off-by: Sasha Levin <sashal@kernel.org> --- drivers/rtc/rtc-pl031.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/rtc/rtc-pl031.c b/drivers/rtc/rtc-pl031.c
index 180caebbd3552..9566958476dfc 100644
--- a/drivers/rtc/rtc-pl031.c
+++ b/drivers/rtc/rtc-pl031.c@@ -379,8 +379,10 @@ static int pl031_probe(struct amba_device *adev, const struct amba_id *id) device_init_wakeup(&adev->dev, true); ldata->rtc = devm_rtc_allocate_device(&adev->dev); - if (IS_ERR(ldata->rtc)) - return PTR_ERR(ldata->rtc); + if (IS_ERR(ldata->rtc)) { + ret = PTR_ERR(ldata->rtc); + goto out; + } ldata->rtc->ops = ops;
--
2.27.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel