On Mon, Dec 14, 2020 at 11:19:48PM +0800, Icenowy Zheng wrote:

于 2020年12月14日 GMT+08:00 下午10:21:18, Maxime Ripard [off-list ref] 写到:

quoted

On Sat, Dec 12, 2020 at 12:04:23PM +0800, Icenowy Zheng wrote:

quoted

V831/V833 are new chips from Allwinner. They're the same die with
different package.

Add a pinctrl driver for them.

The difference between V831/V833 pinctrl is implemented based on the
user manual.

Cc: Linus Walleij <redacted>
Cc: linux-gpio@vger.kernel.org
Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
---
 drivers/pinctrl/sunxi/Kconfig              |   5 +
 drivers/pinctrl/sunxi/Makefile             |   1 +
 drivers/pinctrl/sunxi/pinctrl-sun8i-v83x.c | 743

+++++++++++++++++++++

quoted

 drivers/pinctrl/sunxi/pinctrl-sunxi.h      |   2 +
 4 files changed, 751 insertions(+)
 create mode 100644 drivers/pinctrl/sunxi/pinctrl-sun8i-v83x.c

diff --git a/drivers/pinctrl/sunxi/Kconfig

b/drivers/pinctrl/sunxi/Kconfig

quoted

index 593293584ecc..fc13335a3eda 100644

--- a/drivers/pinctrl/sunxi/Kconfig
+++ b/drivers/pinctrl/sunxi/Kconfig

@@ -73,6 +73,11 @@ config PINCTRL_SUN8I_V3S
 	default MACH_SUN8I
 	select PINCTRL_SUNXI
 
+config PINCTRL_SUN8I_V83X
+	bool "Support for the Allwinner V831/V833 PIO"
+	default MACH_SUN8I
+	select PINCTRL_SUNXI
+

We're not using the wildcard much, and I'd rather be consistent with
the
name / Kconfig option scheme used for the clock driver (and the rest of
the SoCs in a similar situation)

Well, call everything V831, or call everything V833, or call things usable 
on V831 V831 and things only available to V833 V833?

It would feel more natural to have everything called v831, with things
v833-specific obviously called v833

Maxime