Re: [RESEND PATCH 12/19] dt-bindings: Add bindings for USB phy on Allwinner A100

On Sat, Nov 28, 2020 at 08:18:16PM +0000, André Przywara wrote:

On 11/11/2020 22:50, Rob Herring wrote:

Hi,

quoted

On Tue, Nov 10, 2020 at 02:39:42PM +0800, Frank Lee wrote:

quoted

From: Yangtao Li <redacted>

Add a device tree binding for the A100's USB PHY.

Not your fault, Yangto, but why do we actually have a separate binding
document per SoC, when the differences between the PHYs are so minimal
that we get away with some flags in the compatible match, in one driver
file?

They are similar, but there's massive differences between them still
(like which regulators are supposed to be there, or the register names).
So putting them all in the same file just ended up in an unmaintainable
mess.

For a start this file is basically identical to the A64 one (apart from
the example), so can you just add the A100 compatible string to that
one, instead?

But yeah, if two are identical they should be merged

Maxime