Thread (22 messages) 22 messages, 5 authors, 2020-12-02

Re: [PATCH v2 1/2] kbuild: Hoist '--orphan-handling' into Kconfig

From: Masahiro Yamada <masahiroy@kernel.org>
Date: 2020-12-01 13:30:36
Also in: linux-kbuild, linuxppc-dev, lkml

On Sat, Nov 21, 2020 at 9:08 AM Kees Cook [off-list ref] wrote:
On Thu, Nov 19, 2020 at 01:46:56PM -0700, Nathan Chancellor wrote:
quoted
Currently, '--orphan-handling=warn' is spread out across four different
architectures in their respective Makefiles, which makes it a little
unruly to deal with in case it needs to be disabled for a specific
linker version (in this case, ld.lld 10.0.1).

To make it easier to control this, hoist this warning into Kconfig and
the main Makefile so that disabling it is simpler, as the warning will
only be enabled in a couple places (main Makefile and a couple of
compressed boot folders that blow away LDFLAGS_vmlinx) and making it
conditional is easier due to Kconfig syntax. One small additional
benefit of this is saving a call to ld-option on incremental builds
because we will have already evaluated it for CONFIG_LD_ORPHAN_WARN.

To keep the list of supported architectures the same, introduce
CONFIG_ARCH_WANT_LD_ORPHAN_WARN, which an architecture can select to
gain this automatically after all of the sections are specified and size
asserted. A special thanks to Kees Cook for the help text on this
config.

Link: https://github.com/ClangBuiltLinux/linux/issues/1187
Acked-by: Kees Cook <redacted>
Acked-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc)
Reviewed-by: Nick Desaulniers <redacted>
Tested-by: Nick Desaulniers <redacted>
Signed-off-by: Nathan Chancellor <redacted>
Masahiro, do you want to take these to get them to Linus for v5.10? I
can send them if you'd prefer.


Sorry for the delay.

Applied to linux-kbuild.




-Kees

--
Kees Cook

--
You received this message because you are subscribed to the Google Groups "Clang Built Linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to clang-built-linux+unsubscribe@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/clang-built-linux/202011201607.75FA476%40keescook.


-- 
Best Regards
Masahiro Yamada

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help