Re: [PATCH] entry: Fix boot for !CONFIG_GENERIC_ENTRY
From: Naresh Kamboju <hidden>
Date: 2020-11-25 03:36:40
Also in:
bpf, lkml, netdev
On Wed, 25 Nov 2020 at 03:15, Kees Cook [off-list ref] wrote:
On Mon, Nov 23, 2020 at 10:54:58AM -0500, Gabriel Krisman Bertazi wrote:quoted
Gabriel Krisman Bertazi [off-list ref] writes:quoted
Jann Horn [off-list ref] writes:quoted
As part of fixing this, it might be a good idea to put "enum syscall_work_bit" behind a "#ifdef CONFIG_GENERIC_ENTRY" to avoid future accidents like this?Hi Jan, Arnd, That is correct. This is a copy pasta mistake. My apologies. I didn't have a !GENERIC_ENTRY device to test, but just the ifdef would have caught it.I have patched it as suggested. Tested on qemu for arm32 and on bare metal for x86-64. Once again, my apologies for the mistake. -- >8 -- Subject: [PATCH] entry: Fix boot for !CONFIG_GENERIC_ENTRY A copy-pasta mistake tries to set SYSCALL_WORK flags instead of TIF flags for !CONFIG_GENERIC_ENTRY. Also, add safeguards to catch this at compilation time.
This patch tested on arm64, arm, x86_64 and i386 and the reported issue got fixed.
quoted
Reported-by: Naresh Kamboju <redacted> Suggested-by: Jann Horn <jannh@google.com> Signed-off-by: Gabriel Krisman Bertazi <redacted>Thanks for getting this fixed! 3136b93c3fb2 ("entry: Expose helpers to migrate TIF to SYSCALL_WORK flags") Reviewed-by: Kees Cook <redacted>
Tested-by: Naresh Kamboju <redacted> - Naresh _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel