Thread (13 messages) 13 messages, 3 authors, 2020-11-23

Re: [PATCH v6 5/5] regulator: add SCMI driver

From: Mark Brown <broonie@kernel.org>
Date: 2020-11-23 19:11:24
Also in: linux-devicetree, lkml

On Mon, Nov 23, 2020 at 06:49:56PM +0000, Cristian Marussi wrote:
On Mon, Nov 23, 2020 at 05:49:41PM +0000, Mark Brown wrote:
quoted
On Thu, Nov 19, 2020 at 07:10:51PM +0000, Cristian Marussi wrote:
quoted
quoted
+	rinfo->num_doms = num_doms;
+	/*
quoted
Several places like this with missing blank lines.
What do you mean ? a blank before the comment ?
Sorry but checkpatch --strict does not complain, I was not aware of
this styling. I'll do (if you confirm that's what you want)
Yes, a blank line between separate semantic blocks.  This is normal
coding style for the kernel, while checkpatch being a very simple script
can't detect it it's surprising that this seems surprising to you.
How do you prefer these changes (and the DT one) ? 
All as followup patches in a V7 series on top of
sudeep/for-next/scmi-voltage ?
Incremental patches on top of what's applied.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help