Thread (41 messages) 41 messages, 7 authors, 2020-11-25

Re: [PATCH 3/6] tlb: mmu_gather: Remove unused start/end arguments from tlb_finish_mmu()

From: Will Deacon <will@kernel.org>
Date: 2020-11-23 16:49:09
Also in: linux-mm, lkml

On Fri, Nov 20, 2020 at 09:20:43AM -0800, Linus Torvalds wrote:
On Fri, Nov 20, 2020 at 6:36 AM Will Deacon [off-list ref] wrote:
quoted
tlb_finish_mmu() takes two confusing and unused 'start'/'end' address
arguments. Remove them.
Ack, but please add the history to it.

Those arguments were used, up until 7a30df49f63a ("mm: mmu_gather:
remove __tlb_reset_range() for force flush").

And the thing is, using a range flush in theory might be better, but
for simplicity it's now doing a "fullmm" one, which is why those
arguments no longer matter.

(And I think we track the range better now too, which may be another
reason they aren't needed)
Yes, thanks for digging that up. I'll add it to the commit message in v2.

Will

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help