Thread (107 messages) 107 messages, 6 authors, 2020-11-13

Re: [PATCH v9 28/44] arm64: mte: Reset the page tag in page->flags

From: Vincenzo Frascino <vincenzo.frascino@arm.com>
Date: 2020-11-12 09:37:01
Also in: linux-mm, lkml

On 11/12/20 9:31 AM, Catalin Marinas wrote:
On Tue, Nov 10, 2020 at 11:10:25PM +0100, Andrey Konovalov wrote:
quoted
diff --git a/arch/arm64/mm/copypage.c b/arch/arm64/mm/copypage.c
index 70a71f38b6a9..f0efa4847e2f 100644
--- a/arch/arm64/mm/copypage.c
+++ b/arch/arm64/mm/copypage.c
@@ -23,6 +23,7 @@ void copy_highpage(struct page *to, struct page *from)
 
 	if (system_supports_mte() && test_bit(PG_mte_tagged, &from->flags)) {
 		set_bit(PG_mte_tagged, &to->flags);
+		page_kasan_tag_reset(to);
 		mte_copy_page_tags(kto, kfrom);
Any reason why this doesn't have an smp_wmb() between resetting the tags
and copying them into kto?
Yes, the reason is I am not sure why it disappeared from the submitted patch ;)
I am going to respin the patch.

-- 
Regards,
Vincenzo

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help