Re: [PATCH v3 03/11] gpio: raspberrypi-exp: Release firmware handle on unbind
From: Bartosz Golaszewski <hidden>
Date: 2020-11-05 09:09:14
Also in:
linux-clk, linux-devicetree, linux-gpio, linux-input, linux-pwm, lkml
On Wed, Nov 4, 2020 at 11:39 AM Nicolas Saenz Julienne [off-list ref] wrote:
quoted hunk ↗ jump to hunk
Use devm_rpi_firmware_get() so as to make sure we release RPi's firmware interface when unbinding the device. Signed-off-by: Nicolas Saenz Julienne <redacted> --- Changes since v2: - Use devm_rpi_firmware_get(), instead of remove function drivers/gpio/gpio-raspberrypi-exp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/gpio/gpio-raspberrypi-exp.c b/drivers/gpio/gpio-raspberrypi-exp.c index bb100e0124e6..64a552ecc2ad 100644 --- a/drivers/gpio/gpio-raspberrypi-exp.c +++ b/drivers/gpio/gpio-raspberrypi-exp.c@@ -208,7 +208,7 @@ static int rpi_exp_gpio_probe(struct platform_device *pdev) return -ENOENT; } - fw = rpi_firmware_get(fw_node); + fw = devm_rpi_firmware_get(&pdev->dev, fw_node); of_node_put(fw_node); if (!fw) return -EPROBE_DEFER; --2.29.1
Acked-by: Bartosz Golaszewski <redacted> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel