Thread (6 messages) 6 messages, 2 authors, 2020-11-04

Re: Re: [PATCH 0/2] drivers/tty: delete break after return or goto

From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2020-11-04 11:59:19
Also in: linux-serial, lkml

On Wed, Nov 04, 2020 at 07:17:56PM +0800, Bernard wrote:

From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Date: 2020-11-04 19:02:53
To:  Bernard Zhao <redacted>
Cc:  Jiri Slaby <jirislaby@kernel.org>,Shawn Guo <shawnguo@kernel.org>,Sascha Hauer <s.hauer@pengutronix.de>,Pengutronix Kernel Team <kernel@pengutronix.de>,Fabio Estevam <festevam@gmail.com>,NXP Linux Team <redacted>,linux-kernel@vger.kernel.org,linux-serial@vger.kernel.org,linux-arm-kernel@lists.infradead.org,opensource.kernel@vivo.com
Subject: Re: [PATCH 0/2] drivers/tty: delete break after return or goto>On Wed, Nov 04, 2020 at 02:53:29AM -0800, Bernard Zhao wrote:
quoted
quoted
This patch sereies optimise code like:
{
case XXX:
	return XXX;
	break; //The break is meanless, so just delete it.
case YYY:
	goto YYY;
	break; //The break is meanless, so just delete it.
......
}

Signed-off-by: Bernard Zhao <redacted>

---
Bernard Zhao (2):
  drivers/tty/nozomi.c: delete no use break after goto
  drivers/tty/serial/imx.c: delete no use break after return
That is not the subject of the patches you sent out, what broke?
Hi:

I am sorry that I am a little confused:
The patch series`s subject is "drivers/tty: delete break after return or goto"
and the blurb is:
This patch sereies optimise code like:
{
case XXX:
	return XXX;
	break; //The break is meanless, so just delete it.
case YYY:
	goto YYY;
	break; //The break is meanless, so just delete it.
......
}
last, the modified files are:
Bernard Zhao (2):
  drivers/tty/nozomi.c: delete no use break after goto
  drivers/tty/serial/imx.c: delete no use break after return

Is there something wrong that I didn`t catch?
The above lines do not match up with the subject lines of the patches
you sent out, so something went wrong.

thanks,

greg k-h

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help