Re: [PATCH] ARM: kprobes: fix arch_init_kprobes() prototype
From: Masami Hiramatsu <mhiramat@kernel.org>
Date: 2020-10-27 00:41:46
Also in:
lkml
On Mon, 26 Oct 2020 23:12:00 +0100 Arnd Bergmann [off-list ref] wrote:
From: Arnd Bergmann <arnd@arndb.de>
With extra warnings enabled, gcc complains about this function
definition:
arch/arm/probes/kprobes/core.c: In function 'arch_init_kprobes':
arch/arm/probes/kprobes/core.c:465:12: warning: old-style function definition [-Wold-style-definition]
465 | int __init arch_init_kprobes()
Fixes: 24ba613c9d6c ("ARM kprobes: core code")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>Looks good to me. Acked-by: Masami Hiramatsu <mhiramat@kernel.org> Thanks Arnd!
quoted hunk ↗ jump to hunk
--- arch/arm/probes/kprobes/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/arch/arm/probes/kprobes/core.c b/arch/arm/probes/kprobes/core.c index a9653117ca0d..e513d8a46776 100644 --- a/arch/arm/probes/kprobes/core.c +++ b/arch/arm/probes/kprobes/core.c@@ -462,7 +462,7 @@ static struct undef_hook kprobes_arm_break_hook = { #endif /* !CONFIG_THUMB2_KERNEL */ -int __init arch_init_kprobes() +int __init arch_init_kprobes(void) { arm_probes_decode_init(); #ifdef CONFIG_THUMB2_KERNEL-- 2.27.0
-- Masami Hiramatsu [off-list ref] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel