Re: [PATCH 01/10] Revert "arm: sun8i: orangepi-pc-plus: Set EMAC activity LEDs to active high"
From: Jernej Škrabec <hidden>
Date: 2020-10-25 07:29:56
Also in:
linux-devicetree, lkml
Dne sobota, 24. oktober 2020 ob 18:25:06 CET je Chen-Yu Tsai napisal(a):
From: Chen-Yu Tsai <redacted>
This reverts commit 75ee680cbd2e4d0156b94f9fec50076361ab12f2.
Turns out the activity and link LEDs on the RJ45 port are active low,
just like on the Orange Pi PC.
Revert the commit that says otherwise.
Fixes: 75ee680cbd2e ("arm: sun8i: orangepi-pc-plus: Set EMAC activity LEDs to active high")
Fixes: 4904337fe34f ("ARM: dts: sunxi: Restore EMAC changes (boards)")
Signed-off-by: Chen-Yu Tsai <redacted>
---
If you have this board, please help test it.
For me, the correct lighting of the LEDs is both LEDs should be lit
when connected at 100 Mbps.Tested-by: Jernej Skrabec <redacted> Acked-by: Jernej Skrabec <redacted> Best regards, Jernej _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel