Re: [PATCH V2 1/2] opp: Allow dev_pm_opp_get_opp_table() to return -EPROBE_DEFER
From: Viresh Kumar <viresh.kumar@linaro.org>
Date: 2020-10-20 05:54:39
Also in:
linux-pm, linux-samsung-soc, lkml
On 20-10-20, 10:35, Viresh Kumar wrote:
On 19-10-20, 15:10, Sudeep Holla wrote:quoted
On Mon, Oct 19, 2020 at 04:05:35PM +0530, Viresh Kumar wrote:quoted
On 19-10-20, 11:12, Sudeep Holla wrote:quoted
Yes it has clocks property but used by SCMI(for CPUFreq/DevFreq) and not by any clock provider driver. E.g. the issue you will see if "clocks" property is used instead of "qcom,freq-domain" on Qcom parts.Okay, I understand. But what I still don't understand is why it fails for you. You have a clocks property in DT for the CPU, the OPP core tries to get it and will get deferred-probed, which will try probing at a later point of time and it shall work then. Isn't it ?Nope unfortunately. We don't have clock provider, so clk_get will never succeed and always return -EPROBE_DEFER.Now this is really bad, you have a fake clocks property, how is the OPP core supposed to know it ? Damn.
What about instead of fixing the OPP core, which really is doing the right thing, we fix your driver (as you can't fix the DT) and add a dummy CPU clk to make it all work ? -- viresh _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel