Re: [PATCH 1/2] dt-bindings: power: Add bindings document for Charger support on MT6360 PMIC
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2020-10-16 15:38:32
Also in:
linux-devicetree, linux-mediatek, linux-pm, lkml
On Wed, Sep 23, 2020 at 07:18:29PM +0800, Gene Chen wrote:
quoted hunk ↗ jump to hunk
From: Gene Chen <redacted> Add bindings document for Charger support on MT6360 PMIC Signed-off-by: Gene Chen <redacted> --- .../bindings/power/supply/mt6360_charger.yaml | 44 ++++++++++++++++++++++ 1 file changed, 44 insertions(+) create mode 100644 Documentation/devicetree/bindings/power/supply/mt6360_charger.yamldiff --git a/Documentation/devicetree/bindings/power/supply/mt6360_charger.yaml b/Documentation/devicetree/bindings/power/supply/mt6360_charger.yaml new file mode 100644 index 0000000..711fc19 --- /dev/null +++ b/Documentation/devicetree/bindings/power/supply/mt6360_charger.yaml@@ -0,0 +1,44 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/power/supply/mt6360_charger.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Battery charger driver for MT6360 PMIC from MediaTek Integrated. + +maintainers: + - Gene Chen <gene_chen@richtek.com> + +description: | + This module is part of the MT6360 MFD device. + Provides Battery Charger, Boost for OTG devices and BC1.2 detection. + +properties: + compatible: + const: mediatek,mt6360-chg + + vinovp: + description: + Maximum CHGIN regulation voltage.
1. You need to describe the type. 2. Use proper unit suffix (see property-units.txt). 3. Is this a custom property? If yes, it misses vendor prefix. If not, most likely there is already such property. Reuse.
+ + usb-otg-vbus: + $ref: /schemas/regulator/regulator.yaml#
1. Wrong indentation. 2. Name should be more or less generic, so maybe "usb-otg-vbus-regulator".
+ +required: + - compatible
No address/reg? How does it bind?
+
+additionalProperties: false
+
+examples:
+ - |
+ mt6360_chg: chg {s/chg/charger/
+ compatible = "mediatek,mt6360-chg"; + vinovp = <14500000>;
Empty line break Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel