Re: [PATCH v2 10/11] soc: ti: k3-ringacc: Use correct device for allocation in RING mode
From: Peter Ujfalusi <hidden>
Date: 2020-10-09 07:43:14
Also in:
lkml
Nishanth, On 09/10/2020 6.02, Nishanth Menon wrote:
On 14:52-20201008, Peter Ujfalusi wrote:quoted
- ring->ring_mem_virt = dma_alloc_coherent(ringacc->dev, + ring->ring_mem_virt = dma_alloc_coherent(ring->dma_dev, ring->size * (4 << ring->elm_size), &ring->ring_mem_dma, GFP_KERNEL);Any chance of getting a cleanup of the file for 5.11? I know this series has'nt introduced this warning or set of warnings, but I am starting to get concerned that we are carrying over too much of a debt now? https://pastebin.ubuntu.com/p/tT2kPDsCWD/
Right, you know that git blame points the finger at you on ti_sci.c errors? Never the less, I have run the tool locally on my linux-next-wip with these patches: https://pastebin.ubuntu.com/p/myJwjvKYw8/ and I don't see the noise you see.
quoted hunk ↗ jump to hunk
Checkpatch does point this:--- /tmp/kernel-patch-verify.25812/ptest_check-start 2020-10-0819:33:31.025898581 +0000+++ /tmp/kernel-patch-verify.25812/ptest_check-end 2020-10-0819:33:31.593893830 +0000@@ -0,0 +1,6 @@ +CHECK: Alignment should match open parenthesis +#84: FILE: drivers/soc/ti/k3-ringacc.c:657: ++ ring->ring_mem_virt = dma_alloc_coherent(ring->dma_dev, + ring->size * (4 << ring->elm_size),
Yes, that's correct. Readability VS very long lines - Péter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel