-----Original Message-----
From: Greg KH <redacted>
Sent: Friday, October 9, 2020 1:47 PM
To: Joel Stanley <joel@jms.id.au>
Cc: Ryan Chen <ryan_chen@aspeedtech.com>; Andrew Jeffery
[off-list ref]; Linux ARM [off-list ref];
linux-aspeed [off-list ref]; Linux Kernel Mailing List
[off-list ref]; linux-usb@vger.kernel.org; BMC-SW
[off-list ref]; Alan Stern [off-list ref]
Subject: Re: [PATCH v2 1/3] configs: aspeed: enable UHCI driver in defconfig

On Fri, Oct 09, 2020 at 04:55:19AM +0000, Joel Stanley wrote:

quoted

On Fri, 9 Oct 2020 at 04:45, Greg KH [off-list ref] wrote:

quoted

On Fri, Oct 09, 2020 at 10:49:35AM +0800, Ryan Chen wrote:

quoted

v2:
 -Changed : Add SCSI, BLK_DEV_SD, USB_STORAGE support.
v1:
 -Enable UHCI driver in aspeed_g5_defconfig.

Signed-off-by: Ryan Chen <ryan_chen@aspeedtech.com>

Why do you need this in a defconfig?

I would prefer configurations that are being used to be present in the
defconfig so we can test it. I think this is a sensible change.

Then it needs to be described in the changelog, otherwise we have no idea
why this is happening :)

Ok, will send new version describe it. 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel