Re: [PATCH 00/18] use semicolons rather than commas to separate statements
From: Shuah Khan <skhan@linuxfoundation.org>
Date: 2020-10-02 16:47:20
Also in:
kernel-janitors, linux-acpi, linux-amlogic, linux-block, linux-clk, linux-crypto, linux-ide, linux-iio, linux-wireless, lkml
On 9/29/20 7:42 AM, Shuah Khan wrote:
On 9/29/20 7:34 AM, Joe Perches wrote:quoted
On Tue, 2020-09-29 at 14:47 +0200, Julia Lawall wrote:quoted
On Tue, 29 Sep 2020, Dan Carpenter wrote:quoted
The times where commas are used deliberately to replace curly braces are just evil. Either way the code is cleaner with semi-colons.I also found exaamples like the following to be particularly unforunate: fprintf(stderr, "page_nr %lu wrong count %Lu %Lu\n", page_nr, count, count_verify[page_nr]), exit(1); The exit is very hard to see, unless you know to look for it.I sent that patch last month. https://patchwork.kernel.org/patch/11734877/I see what happened. This patch touches lib, cpupower, and selftests. Guess lost in the limbo of who takes it. tools/lib/subcmd/help.c | 10 +- tools/power/cpupower/utils/cpufreq-set.c | 14 +- tools/testing/selftests/vm/gup_benchmark.c | 18 +- tools/testing/selftests/vm/userfaultfd.c | 296 +++++++++++++-------- 4 files changed, 210 insertions(+), 128 deletions(-) I can take it through one of my trees.
Rafael, Andrew, This patch is now applied to https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git fixes branch. This spans pm, kselftest-mm tests and tools/lib and has been in limbo for a few weeks for that reason. I decided to take this through kselftest tree to avoid having Joe split the patches. thanks, -- Shuah _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel