Re: [PATCH 1/2] drm/vc4: kms: Assign a FIFO to enabled CRTCs instead of active
flat view
From: Hoegeun Kwon <hidden>
Date: 2020-09-24 08:11:06
Also in:
dri-devel
Hi Maxime, On 9/18/20 11:59 PM, Maxime Ripard wrote:
The HVS has three FIFOs that can be assigned to a number of PixelValves through a mux. However, changing that FIFO requires that we disable and then enable the pixelvalve, so we want to assign FIFOs to all the enabled CRTCs, and not just the active ones.
Thanks for the patch. There is a problem when doing page flip. After connecting 2 HDMIs without hotplug and booting.(Same thing when using hotplug.) When executing page flip for each of HDMI 0 and 1 in modetest operation does not work normally. (crtc irq does not occur, so timeout occurs.) Sometimes both hdmi 0 or 1 work or not. LOGs: root:~> modetest -Mvc4 -s 32:1280x720 -v setting mode 1280x720-60Hz@XR24 on connectors 32, crtc 64 failed to set gamma: Invalid argument freq: 60.24Hz freq: 60.00Hz root:~> modetest -Mvc4 -s 38:1280x720 -v setting mode 1280x720-60Hz@XR24 on connectors 38, crtc 69 failed to set gamma: Invalid argument select timed out or error (ret 0) select timed out or error (ret 0) Could you please check it? Best regards, Hoegeun
quoted hunk ↗ jump to hunk
Fixes: 87ebcd42fb7b ("drm/vc4: crtc: Assign output to channel automatically") Signed-off-by: Maxime Ripard <redacted> --- drivers/gpu/drm/vc4/vc4_kms.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/gpu/drm/vc4/vc4_kms.c b/drivers/gpu/drm/vc4/vc4_kms.c index af3ee3dcdab6..01fa60844695 100644 --- a/drivers/gpu/drm/vc4/vc4_kms.c +++ b/drivers/gpu/drm/vc4/vc4_kms.c@@ -643,7 +643,7 @@ vc4_atomic_check(struct drm_device *dev, struct drm_atomic_state *state) struct vc4_crtc *vc4_crtc = to_vc4_crtc(crtc); unsigned int matching_channels; - if (!crtc_state->active) + if (!crtc_state->enable) continue; /*
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel