Re: [PATCH v4 07/15] drivers/firmware/sdei: Remove Drop redundant error message in sdei_probe()
From: James Morse <james.morse@arm.com>
Date: 2020-09-18 16:14:32
Hi Gavin, (Subject nit: Drop should have a lower case d) On 30/07/2020 02:45, Gavin Shan wrote:
This removes the redundant error message in sdei_probe() because the case can be identified from the errno in next error message.
... assuming anyone knows what -95 means. This is meant to be helpful, to tell people they have incomplete firmware.
quoted hunk ↗ jump to hunk
diff --git a/drivers/firmware/arm_sdei.c b/drivers/firmware/arm_sdei.c index 240c06ae7bfe..03b1179da9b4 100644 --- a/drivers/firmware/arm_sdei.c +++ b/drivers/firmware/arm_sdei.c@@ -982,8 +982,6 @@ static int sdei_probe(struct platform_device *pdev) return 0; err = sdei_api_get_version(&ver); - if (err == -EOPNOTSUPP) - pr_err("advertised but not implemented in platform firmware\n"); if (err) { pr_err("Failed to get SDEI version: %d\n", err); sdei_mark_interface_broken();
Given the firmware implementation is upstream in ATF, I guess no-one will create their own. Acked-by: James Morse <james.morse@arm.com> Thanks, James _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel