Gently ping again...

@Stephen Boyd
Could you kindly provide some feedback how we can proceed this?

Regards
Aisheng

From: Dong Aisheng <redacted>
Sent: Wednesday, September 2, 2020 2:36 PM

Hi Stephen,

Would you help look at this?
Now only one patch left that still does not have a R-b tag and needs your review.
[PATCH v7 03/11] clk: imx: scu: add two cells binding support All other patches
already get R-b tags.

Regards
Aisheng

On Mon, Aug 17, 2020 at 3:42 PM Dong Aisheng [off-list ref]
wrote:

quoted

Gently ping...

On Wed, Jul 29, 2020 at 4:04 PM Dong Aisheng [off-list ref]

wrote:

quoted

quoted

Hi Stephen,

This patchset addressed all your new comments.
Right now only Patch 2/3 still haven't got any R-b or A-b tags. So
still need your help to review.
All other patches already got the R-b tags.

BTW, for [PATCH v7 02/11] dt-bindings: clock: imx-lpcg: add support
to parse  clocks from device tree.
It was reviewed by Rob/Shawn and you before, however, due to the
legacy binding file has been removed and changed to json format.
So this patch also updated to json format accordingly based on the
former reviewed patch and need a re-review.

Regards
Aisheng

On Wed, Jul 29, 2020 at 4:04 PM Dong Aisheng [off-list ref]

wrote:

quoted

quoted

quoted

This patch series is a preparation for the MX8 Architecture improvement.
As for IMX SCU based platforms like MX8QM and MX8QXP, they are
comprised of a couple of SS(Subsystems) while most of them within
the same SS can be shared. e.g. Clocks, Devices and etc.

However, current clock binding is using SW IDs for device tree to
use which can cause troubles in writing the common
<soc>-ss-xx.dtsi file for different SoCs.

This patch series aims to introduce a new binding which is more
close to hardware and platform independent and can makes us write
a more general drivers for different SCU based SoCs.

Another important thing is that on MX8, each Clock resource is
associated with a power domain. So we have to attach that clock
device to the power domain in order to make it work properly.
Further more, the clock state will be lost when its power domain
is completely off during suspend/resume, so we also introduce the clock

state save&restore mechanism.

quoted

quoted

quoted

It's based on latest shanw/for-next branch.

The top commit is:
3c1a41dab7b8 Merge branch 'imx/defconfig' into for-next

ChangeLog:
v6->v7:
 * addressed all comments from Stephen
 * rebased to latest shawn/for-next
v5->v6:
 * add scu clk unregister if add provider failed
v4->v5:
 * Address all comments from Stephen
v3->v4:
 * use clk-indices for LPCG to fetch each clks offset from dt
v2->v3:
 * change scu clk into two cells binding
 * add clk pm patches to ease the understand of the changes
v1->v2:
 * SCU clock changed to one cell clock binding inspired by arm,scpi.txt
   Documentation/devicetree/bindings/arm/arm,scpi.txt
 * Add required power domain property
 * Dropped PATCH 3&4 first, will send the updated version accordingly
   after the binding is finally determined,

Dong Aisheng (11):
  dt-bindings: firmware: imx-scu: new binding to parse clocks from
    device tree
  dt-bindings: clock: imx-lpcg: add support to parse clocks from device
    tree
  clk: imx: scu: add two cells binding support
  clk: imx: scu: bypass cpu power domains
  clk: imx: scu: allow scu clk to take device pointer
  clk: imx: scu: add runtime pm support
  clk: imx: scu: add suspend/resume support
  clk: imx: imx8qxp-lpcg: add parsing clocks from device tree
  clk: imx: lpcg: allow lpcg clk to take device pointer
  clk: imx: clk-imx8qxp-lpcg: add runtime pm support
  clk: imx: lpcg: add suspend/resume support

 .../bindings/arm/freescale/fsl,scu.txt        |  12 +-
 .../bindings/clock/imx8qxp-lpcg.yaml          |  79 ++++--
 drivers/clk/imx/clk-imx8qxp-lpcg.c            | 139 +++++++++++
 drivers/clk/imx/clk-imx8qxp.c                 | 136 +++++-----
 drivers/clk/imx/clk-lpcg-scu.c                |  53 +++-
 drivers/clk/imx/clk-scu.c                     | 234

+++++++++++++++++-

quoted

quoted

quoted

 drivers/clk/imx/clk-scu.h                     |  56 ++++-
 include/dt-bindings/clock/imx8-lpcg.h         |  14 ++
 8 files changed, 620 insertions(+), 103 deletions(-)  create mode
100644 include/dt-bindings/clock/imx8-lpcg.h

--
2.23.0

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel