Thread (10 messages) 10 messages, 2 authors, 2020-10-27

RE: [PATCH 4/4] scsi: ufs-mediatek: Add host reset mechanism

From: Avri Altman <Avri.Altman@wdc.com>
Date: 2020-09-29 11:54:58
Also in: linux-mediatek, linux-scsi, lkml


Add host reset mechanism to try to recover host-side errors
during recovery flow.

Signed-off-by: Stanley Chu <redacted>
Reviewed-by Avri Altman [off-list ref]

See some nit below as well.
Thanks,
Avri
+static void ufs_mtk_init_reset_control(struct ufs_hba *hba,
+                                      struct reset_control **rc,
+                                      char *str)
+{
+       *rc = devm_reset_control_get(hba->dev, str);
+       if (IS_ERR(*rc)) {
How about verifying that the line is not shared as well?
Although this might not be an issue on your current platforms,
it might save you aggravation in the future..
+               dev_info(hba->dev, "Failed to get reset control %s: %d\n",
+                        str, PTR_ERR(*rc));
+               *rc = NULL;
+       }
+}
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help