Thread (5 messages) 5 messages, 3 authors, 2020-09-30

Re: [PATCH -next] pinctrl: mediatek: simplify the return expression of mtk_pinconf_bias_disable_set_rev1()

From: Sean Wang <sean.wang@kernel.org>
Date: 2020-09-27 18:39:18
Also in: linux-gpio, linux-mediatek, lkml

On Mon, Sep 21, 2020 at 6:10 AM Qinglang Miao [off-list ref] wrote:
Simplify the return expression.

Signed-off-by: Qinglang Miao <redacted>
Acked-by: Sean Wang <sean.wang@kernel.org>
quoted hunk ↗ jump to hunk
---
 drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
index 2f3dfb56c..16bb15226 100644
--- a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
+++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c
@@ -479,14 +479,8 @@ EXPORT_SYMBOL_GPL(mtk_pinconf_bias_get);
 int mtk_pinconf_bias_disable_set_rev1(struct mtk_pinctrl *hw,
                                      const struct mtk_pin_desc *desc)
 {
-       int err;
-
-       err = mtk_hw_set_value(hw, desc, PINCTRL_PIN_REG_PULLEN,
-                              MTK_DISABLE);
-       if (err)
-               return err;
-
-       return 0;
+       return mtk_hw_set_value(hw, desc, PINCTRL_PIN_REG_PULLEN,
+                               MTK_DISABLE);
 }
 EXPORT_SYMBOL_GPL(mtk_pinconf_bias_disable_set_rev1);

--
2.23.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help