Re: [PATCH v2 2/9] ARM: traps: use get_kernel_nofault instead of set_fs()
From: Christoph Hellwig <hch@infradead.org>
Date: 2020-09-19 05:27:50
Also in:
linux-arch, linux-mm, lkml
From: Christoph Hellwig <hch@infradead.org>
Date: 2020-09-19 05:27:50
Also in:
linux-arch, linux-mm, lkml
On Fri, Sep 18, 2020 at 02:46:17PM +0200, Arnd Bergmann wrote:
ARM uses set_fs() and __get_user() to allow the stack dumping code to access possibly invalid pointers carefully. These can be changed to the simpler get_kernel_nofault(), and allow the eventual removal of set_fs(). dump_instr() will print either kernel or user space pointers, depending on how it was called. For dump_mem(), I assume we are only interested in kernel pointers, and the only time that this is called with user_mode(regs)==true is when the regs themselves are unreliable as a result of the condition that caused the trap. Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Looks good, Reviewed-by: Christoph Hellwig <hch@lst.de> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel