Re: [PATCH v4 1/3] dt-bindings: iio: adc: add bindings doc for MT6360 ADC
From: Jonathan Cameron <jic23@kernel.org>
Date: 2020-09-17 17:34:21
Also in:
linux-devicetree, linux-iio, linux-mediatek, lkml
On Wed, 16 Sep 2020 01:36:07 +0800 Gene Chen [off-list ref] wrote:
From: Gene Chen <redacted> This change adds the binding doc for the MT6360 ADC. Signed-off-by: Gene Chen <redacted>
Hi Gene A few things inline I missed before. Ideally this wants a device-tree ack which it isn't likely to get without cc'ing the binding Maintainers. I've added Rob and the list. Thanks, Jonathan
quoted hunk ↗ jump to hunk
--- .../bindings/iio/adc/mediatek,mt6360.yaml | 32 ++++++++++++++++++++++ 1 file changed, 32 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/adc/mediatek,mt6360.yamldiff --git a/Documentation/devicetree/bindings/iio/adc/mediatek,mt6360.yaml b/Documentation/devicetree/bindings/iio/adc/mediatek,mt6360.yaml new file mode 100644 index 0000000..2fa2fe7 --- /dev/null +++ b/Documentation/devicetree/bindings/iio/adc/mediatek,mt6360.yaml@@ -0,0 +1,32 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/iio/adc/mediatek,mt6360.yaml#
I think this should probably match the compatible as should the file name. (sorry missed this on previous review!)
+$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Mediatek MT6360 and similar ADCs + +maintainers: + - Gene Chen [off-list ref] + +description: | + Family of simple ADCs with i2c interface and internal references. + +properties: + compatible: + const: mediatek,mt6360-adc + + "#io-channel-cells": + const: 1 + +required: + - compatible + - "#io-channel-cells"
As it's fresh in my mind from forgetting it myself, can we add additionalProperties: false ?
+
+examples:
+ - |
+ adc {
+ compatible = "mediatek,mt6360-adc";
+ #io-channel-cells = <1>;
+ };
+..._______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel