On Wed, 16 Sep 2020 at 03:01, Dmitry Torokhov [off-list ref] wrote:

On Fri, Aug 28, 2020 at 04:57:44PM +0200, Krzysztof Kozlowski wrote:

quoted

platform_get_irq() returns -ERRNO on error.  In such case comparison
to 0 would pass the check.

Fixes: e443631d20f5 ("Input: serio - add support for Alwinner A10/A20 PS/2 controller")
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

---

Changes since v1:
1. None
---
 drivers/input/serio/sun4i-ps2.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/input/serio/sun4i-ps2.c b/drivers/input/serio/sun4i-ps2.c
index a681a2c04e39..7da1ea8741fc 100644
--- a/drivers/input/serio/sun4i-ps2.c
+++ b/drivers/input/serio/sun4i-ps2.c

@@ -265,9 +265,8 @@ static int sun4i_ps2_probe(struct platform_device *pdev)

      /* Get IRQ for the device */
      irq = platform_get_irq(pdev, 0);
-     if (!irq) {
-             dev_err(dev, "no IRQ found\n");
-             error = -ENXIO;
+     if (irq < 0) {

"irq" is unsigned here, so this will not work. I'll change it to use
drvdat->irq which happens to be signed, and drop "irq" variable.

Yes, thanks. I wonder now why there was no warning of unsigned<0 comparison.

Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel