Thread (4 messages) 4 messages, 2 authors, 2020-09-14

Re: [PATCH 1/2] tty: serial: print earlycon info after match->setup

From: Hsin-Yi Wang <hidden>
Date: 2020-09-14 17:28:41
Also in: linux-mediatek, linux-serial, lkml

On Tue, Sep 15, 2020 at 12:06 AM Andy Shevchenko
[off-list ref] wrote:
On Fri, Sep 11, 2020 at 05:39:26PM +0800, Hsin-Yi Wang wrote:
quoted
8250 devices may modify iotype in their own earlycon setup. For example:
8250_mtk and 8250_uniphier force iotype to be MMIO32. Print earlycon info
after match->setup to reflect actual earlycon info.
But this means you do something which user didn't ask for...
8250_uniphier states that it can only use mmio32
https://elixir.bootlin.com/linux/v5.9-rc4/source/drivers/tty/serial/8250/8250_uniphier.c#L46

For MTK, may be the same case. So they are set in the driver.
quoted
+static void __init earlycon_info(struct earlycon_device *device)
Can it be earlycon_pr_info() or earlycon_print_info() ?
Sure. I'll send a v2.
--
With Best Regards,
Andy Shevchenko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help