Re: [PATCH 1/3] pinctrl: aspeed: Format pinconf debug consistent with pinmux
From: Joel Stanley <joel@jms.id.au>
Date: 2020-09-10 02:06:04
Also in:
linux-aspeed, linux-gpio, lkml, openbmc
On Wed, 9 Sep 2020 at 11:43, Andrew Jeffery [off-list ref] wrote:
quoted hunk ↗ jump to hunk
When displaying which pinconf register and field is being touched, format the field mask so that it's consistent with the way the pinmux portion formats the mask. Signed-off-by: Andrew Jeffery <redacted> --- drivers/pinctrl/aspeed/pinctrl-aspeed.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)diff --git a/drivers/pinctrl/aspeed/pinctrl-aspeed.c b/drivers/pinctrl/aspeed/pinctrl-aspeed.c index 53f3f8aec695..d8972911d505 100644 --- a/drivers/pinctrl/aspeed/pinctrl-aspeed.c +++ b/drivers/pinctrl/aspeed/pinctrl-aspeed.c@@ -539,9 +539,9 @@ int aspeed_pin_config_set(struct pinctrl_dev *pctldev, unsigned int offset, if (rc < 0) return rc; - pr_debug("%s: Set SCU%02X[%lu]=%d for param %d(=%d) on pin %d\n", - __func__, pconf->reg, __ffs(pconf->mask), - pmap->val, param, arg, offset); + pr_debug("%s: Set SCU%02X[0x%08X]=%d for param %d(=%d) on pin %d\n",
The pr_debug in pinmux-aspeed.c prints val as 0x%X. Did you want to do that here?
+ __func__, pconf->reg, pconf->mask,
+ val, param, arg, offset);
}
return 0;
--
2.25.1_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel