Thread (2 messages) 2 messages, 2 authors, 2020-09-07

Re: [PATCH] arm64: PCI: fix memleak when calling pci_iomap/unmap()

From: Catalin Marinas <catalin.marinas@arm.com>
Date: 2020-09-07 10:46:01
Also in: linux-pci, lkml

On Sat, Sep 05, 2020 at 10:48:11AM +0800, Yang Yingliang wrote:
quoted hunk ↗ jump to hunk
diff --git a/arch/arm64/kernel/pci.c b/arch/arm64/kernel/pci.c
index 1006ed2d7c604..ddfa1c53def48 100644
--- a/arch/arm64/kernel/pci.c
+++ b/arch/arm64/kernel/pci.c
@@ -217,4 +217,9 @@ void pcibios_remove_bus(struct pci_bus *bus)
 	acpi_pci_remove_bus(bus);
 }
 
+void pci_iounmap(struct pci_dev *dev, void __iomem *addr)
+{
+	iounmap(addr);
+}
+EXPORT_SYMBOL(pci_iounmap);
So, what's wrong with the generic pci_iounmap() implementation?
Shouldn't it call iounmap() already?

-- 
Catalin

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help