Re: [PATCH 07/10] clk: meson: Simplify with dev_err_probe()
From: Jerome Brunet <jbrunet@baylibre.com>
Date: 2020-09-07 08:30:50
Also in:
linux-amlogic, linux-arm-msm, linux-clk, lkml
On Wed 02 Sep 2020 at 17:03, Krzysztof Kozlowski [off-list ref] wrote:
Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and the error value gets printed. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Jerome Brunet <jbrunet@baylibre.com>
quoted hunk ↗ jump to hunk
--- drivers/clk/meson/axg-audio.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)diff --git a/drivers/clk/meson/axg-audio.c b/drivers/clk/meson/axg-audio.c index 53715e36326c..dc22b0c45743 100644 --- a/drivers/clk/meson/axg-audio.c +++ b/drivers/clk/meson/axg-audio.c@@ -1509,12 +1509,8 @@ static int devm_clk_get_enable(struct device *dev, char *id) int ret; clk = devm_clk_get(dev, id); - if (IS_ERR(clk)) { - ret = PTR_ERR(clk); - if (ret != -EPROBE_DEFER) - dev_err(dev, "failed to get %s", id); - return ret; - } + if (IS_ERR(clk)) + return dev_err_probe(dev, PTR_ERR(clk), "failed to get %s", id); ret = clk_prepare_enable(clk); if (ret) {
_______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel