Re: [PATCH 6/7] dt-bindings: i2c: imx: Use unevaluatedProperties
From: Rob Herring <robh@kernel.org>
Date: 2020-09-04 14:30:50
Also in:
linux-clk, linux-devicetree, linux-i2c, lkml
On Thu, Sep 3, 2020 at 2:36 PM Krzysztof Kozlowski [off-list ref] wrote:
On Thu, 3 Sep 2020 at 18:41, Rob Herring [off-list ref] wrote:quoted
On Sat, Aug 29, 2020 at 01:17:59PM +0200, Krzysztof Kozlowski wrote:quoted
Additional properties actually might appear (e.g. power-domains or child nodes) so use unevaluatedProperties to fix dtbs_check warnings like: arch/arm64/boot/dts/freescale/imx8mn-evk.dt.yaml: i2c@30a20000: '#address-cells', '#size-cells', 'pmic@25' do not match any of the regexes: 'pinctrl-[0-9]+' Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- Documentation/devicetree/bindings/i2c/i2c-imx.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)NAK. See https://lore.kernel.org/r/CAL_JsqKPXJxsHPS34_TCf9bwgKxZNSV4mvQR-WKRnknQVtGGxQ@mail.gmail.com/ (local)I can reference the generic i2c-controller schema and add missing properties but what to do with children (pmic@25 and many other)? I see that all of the other I2C controller dtschema files solve it by skipping "additionalProperties: false". Is this the way to go with I2C controllers?
If there's a $ref to the i2c schema, then using unevaluatedProperties is correct. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel