Thread (12 messages) flat view 12 messages, 3 authors, 2020-09-10

Re: [PATCH v2 3/3] arm64: stacktrace: Convert to ARCH_STACKWALK

From: Miroslav Benes <mbenes@suse.cz>
Date: 2020-09-02 09:32:19
Also in: linux-s390, lkml

Hi,

it could be a silly question, but better to ask...
+	if (regs)
+		start_backtrace(&frame, regs->regs[29], regs->pc);
+	else
+		start_backtrace(&frame, thread_saved_fp(task),
+				thread_saved_pc(task));
Would this also work for task == current? Given that the original code had
-		start_backtrace(&frame,
-				(unsigned long)__builtin_frame_address(0),
-				(unsigned long)__save_stack_trace);
for the case, which seems correct (but I don't know much about arm64 arch 
in the kernel).

Otherwise, I did not spot anything suspicious or wrong.

Regards
Miroslav

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help