Thread (49 messages) 49 messages, 3 authors, 2020-08-04

Re: [PATCH v6 08/25] coresight: etm: perf: Fix warning caused by etm_setup_aux failure

From: Mike Leach <hidden>
Date: 2020-08-03 17:13:37

On Fri, 31 Jul 2020 at 07:41, Tingwei Zhang [off-list ref] wrote:
quoted hunk ↗ jump to hunk
When coresight_build_path() fails on all the cpus, etm_setup_aux
calls etm_free_aux() to free allocated event_data.
WARN_ON(cpumask_empty(mask) will be triggered since cpu mask is empty.
Check event_data->snk_config is not NULL first to avoid this
warning.

Signed-off-by: Tingwei Zhang <redacted>
---
 drivers/hwtracing/coresight/coresight-etm-perf.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/hwtracing/coresight/coresight-etm-perf.c b/drivers/hwtracing/coresight/coresight-etm-perf.c
index dcb0592418ae..3728c44e5763 100644
--- a/drivers/hwtracing/coresight/coresight-etm-perf.c
+++ b/drivers/hwtracing/coresight/coresight-etm-perf.c
@@ -126,10 +126,10 @@ static void free_sink_buffer(struct etm_event_data *event_data)
        cpumask_t *mask = &event_data->mask;
        struct coresight_device *sink;

-       if (WARN_ON(cpumask_empty(mask)))
+       if (!event_data->snk_config)
                return;

-       if (!event_data->snk_config)
+       if (WARN_ON(cpumask_empty(mask)))
                return;

        cpu = cpumask_first(mask);
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
Reviewed by: Mike Leach [off-list ref]


--
Mike Leach
Principal Engineer, ARM Ltd.
Manchester Design Centre. UK

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help